jsonforms-renderers(spreadsheet): separate spreadsheet matrix processing from parsing - #31
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughChangesSpreadsheet processing
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR extracts existing spreadsheet matrix processing into a reusable helper without changing parsing or persisted data behavior. It is merge-ready after normal checks, with no actionable merge-blocking risk remaining. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 tasks
sthanikan2000
force-pushed
the
feat/spreadsheet-parse-process-split
branch
2 times, most recently
from
August 31, 2026 07:19
a3a3a83 to
f10285a
Compare
sthanikan2000
force-pushed
the
feat/spreadsheet-parse-process-split
branch
from
August 31, 2026 07:23
f10285a to
9853559
Compare
sthanikan2000
changed the title
sthanikan2000
marked this pull request as ready for review
September 2, 2026 01:30
4 tasks
sthanikan2000
force-pushed
the
feat/spreadsheet-parse-process-split
branch
from
September 3, 2026 09:19
9853559 to
2904386
Compare
Extracts the "evaluate formulas against an already-parsed matrix, then shape the persisted value" step out of SpreadsheetControl's processFile callback into a standalone, format-agnostic processMatrix() helper. parseWorkbookToMatrix (xlsx/csv-specific) is untouched; a future XML-upload path that produces the same CellValue[][] matrix shape can reuse processMatrix without duplicating the evaluate-and-shape logic. Also relocates the SpreadsheetValue type out of SpreadsheetControl.tsx into the shared utils/spreadsheet types, since it's no longer private to one renderer. Pure, behavior-preserving refactor — derivations stay array-shaped here, unchanged from main; see the next PR for the id-keyed map change. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
sthanikan2000
force-pushed
the
feat/spreadsheet-parse-process-split
branch
from
September 6, 2026 06:05
2904386 to
742ff1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pure, behavior-preserving refactor: extracts the "evaluate formulas against an already-parsed matrix, then shape the persisted value" step out of
SpreadsheetControl'sprocessFilecallback into a standalone, format-agnosticprocessMatrix()helper (newutils/spreadsheet/process.ts).parseWorkbookToMatrix(xlsx/csv-specific) is untouched.CellValue[][]matrix shape (e.g. XML) could reuseprocessMatrixwithout duplicating the evaluate-and-shape logic — no such format is added here, this PR only creates the reusable seam.SpreadsheetValueout ofSpreadsheetControl.tsxinto the sharedutils/spreadsheettypes, since it's no longer private to one renderer.derivationsstays array-shaped here, unchanged frommain— the next PR in the stack adds mandatoryidand converts this to an id-keyed map, deliberately split out so this PR stays a genuine no-behavior-change refactor with noidconcept involved at all.(Replaces the original #25, which GitHub auto-flagged as "merged" after a stack-restructuring force-push made its old head commit reachable from its old base branch — no code ever reached
main; this PR carries the same content rebased directly onto #23.)Test plan
pnpm type-checkandpnpm testpass (newprocess.test.tscoverspersistSheettrue/false, empty formulas, error-entry passthrough)🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Bug Fixes
Tests